Open
Conversation
vanhaj
approved these changes
Mar 1, 2022
vanhaj
left a comment
vanhaj
left a comment
There was a problem hiding this comment.
I'm really impressed with your work, week 7 was a tough week!
Love that you stuck to one type of color, makes it look neater.
I really enjoyed looking at your solutions!
Your code looks really clean and it is easy to follow.
Keep up the good work! :)
| `<img class="user-image" src=${data.avatar_url}/>` | ||
| userInfo.innerHTML= | ||
| `<h1>${data.name}</h1> | ||
| <h3> | ${data.login}</h3>` |
There was a problem hiding this comment.
Great job with fetching the img and username!
A tip to make it even more clever is to wrap the <h3> in <a> tag and add ${data.html_url} to link the username to your github profile.
| fetch (API_URL, options) | ||
| .then((res) => res.json()) | ||
| .then((data) => { | ||
| const filterTechnigoProjects = data.filter((repo) => repo.fork && repo.name.startsWith("project")) |
There was a problem hiding this comment.
Nice solution with filtering only those that starts with "project"!
| `<div class="repocard" id=${projectID}> | ||
| <a href=${repo.html_url}><h3> ${repo.name}</h3></a> | ||
| <p> Default branch: ${repo.default_branch}</p> | ||
| <p> Latest push: ${new Date(repo.pushed_at).toDateString()}</p> |
There was a problem hiding this comment.
Awsome job with .toDateString I will use that the next time!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.